fix: resolve 8 reliability bugs + ~500 code smells for SonarCloud quality gate#39
Merged
Conversation
…tants, dead code Reliability bugs (8 fixed): - S2159: GitHubActionsDetector equals() on unrelated types (Boolean vs String) - S5998: NestJSControllerDetector, RawSqlDetector regex stack overflow risk (added possessive quantifiers) - S5850: CSharpStructuresDetector regex precedence (explicit grouping) - S5855: GrpcServiceDetector redundant regex alternative Unused imports (S1128, ~113 removed across 76 files) String literal constants (S1192, ~281 constants extracted across 75 files): - PROP_FRAMEWORK, PROP_AUTH_TYPE, PROP_TOPIC, etc. Dead code cleanup: - S1481: Removed ~20 unused local variables - S1854: Removed ~16 dead stores - S1172: Removed ~20 unused method parameters (private methods only) - S1130: Removed ~18 unnecessary throws declarations - S1659: Split ~18 multi-variable declarations - S108: Added comments in ~13 empty blocks Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes SonarCloud quality gate failures: 8 reliability bugs and ~500 maintainability code smells resolved without changing any detector behavior.
Reliability Bugs Fixed (8)
Boolean.TRUE.equals(key)→"on".equals(String.valueOf(key))Code Smells Fixed (~500)
Test plan
🤖 Generated with Claude Code